Treat token expirations as fatal errors #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify: because we're proactively expiring tokens, we should never actually wind up in a situation where the token has expired. Closing the connection deals what should be an exceptional case rather than serving as the primary mechanism for rotating tokens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a spiritual follow-on to #747, this fixes #568 by simply closing connections when the server thinks tokens have expired.
My best idea right now is that the server simply doesn't let connections use new tokens after one has actually expired and continues to respond to all subsequent notifications with an "expired token" response. If that's the case, our best recourse is to just close the connection and open a new one.