Round-robin DNS resolution #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchambers
commented
Mar 31, 2018
| @@ -84,7 +85,8 @@ | |||
| this.bootstrapTemplate.option(ChannelOption.TCP_NODELAY, true); | |||
| this.bootstrapTemplate.remoteAddress(apnsServerAddress); | |||
| this.bootstrapTemplate.resolver(proxyHandlerFactory == null ? | |||
| DefaultAddressResolverGroup.INSTANCE : NoopAddressResolverGroup.INSTANCE); | |||
| new RoundRobinDnsAddressResolverGroup(ClientChannelClassUtil.getDatagramChannelClass(eventLoopGroup), | |||
There was a problem hiding this comment.
For readers/reviewers, this is the key change. Pretty much everything else is just adding dependencies on Netty's DNS resolver module or expanding ClientChannelClassUtil to cover datagram sockets, too.
jchambers
force-pushed
the
round_robin_resolver_group
branch
2 times, most recently
from
85dc568 to
9db228f
Compare
…ctions across APNs servers.
jchambers
force-pushed
the
round_robin_resolver_group
branch
from
9db228f to
cb3d741
Compare
|
This change leads to UDP socket leaks. Every instance of AddressResolverGroup subscribes to EventLoopGroup#terminationFuture. When EventLoopGroup is shared between several ApnsClient instances there is no way correctly terminate that resolvers as ApnsClient#close does not remove instance of resolver. |
|
@palex-fpt Good catch. Could you please file a separate issue for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a round-robin DNS resolver. This will allow clients to spread their concurrent connections across a range of APNs and should, as a side effect of using Netty's DNS resolver, notice changes in the server list more quickly.
It has no effect if the client is using a proxy.