Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works for Gutenberg and option-pages #73

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

jhotadhari
Copy link

  • Changed script to target #wpwrap if #post is not existing. #wpwrap exists on Gutenberg and option-pages.
  • Changed conditions whether the script will be enqueued or not.
  • Added filter cmb2_conditionals_enqueue_script. Possibility to skip or force enqueuing of the script.
  • Added filter cmb2_conditionals_enqueue_script_src. Possibility to change script source.

might solve issues:

- Changed script to target `#wpwrap` if `#post` is not existing. `#wpwrap` exists on Gutenberg and option-pages.
- Changed conditions whether the script will be enqueued or not.
- Added filter `cmb2_conditionals_enqueue_script`. Possibility to skip or force enqueuing of the script.
- Added filter `cmb2_conditionals_enqueue_script_src`. Possibility to change script source.
@jcchavezs
Copy link
Owner

Thanks @jhotadhari

@jcchavezs jcchavezs merged commit 6c8cafc into jcchavezs:master Apr 24, 2019
jhotadhari added a commit to croox/generator-wp-dev-env that referenced this pull request Apr 25, 2019
### subgenerator `assets`
- possible to add script and/or style in frontend and/or admin.

### subgenerator `composerPackage`
- change version of composerPackage `jcchavezs/cmb2-conditionals` to `dev-master`, pull request got merged jcchavezs/cmb2-conditionals#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants