Test for Logistic Regression #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarreira
requested changes
Dec 15, 2018
|
Please fix the conflict |
jcarreira
requested changes
Mar 3, 2019
| @@ -0,0 +1,29 @@ | |||
| import time | |||
|
|
|||
| from cirrus import instance, automate, lr | |||
| @@ -0,0 +1,29 @@ | |||
| import time | |||
|
|
|||
There was a problem hiding this comment.
I would change the name of this file and function since "test" seems a bit vague.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "test(server)" |
There was a problem hiding this comment.
You should explain what this function does so the user know what's going on. Like we do in the other notebooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for the python end for logistic regression (i.e checks if the accuracy increases beyond a certain threshold).