added jakarta namespace #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PeJetuz thanks for your contribution! It's good to have these deps in jcabi-parent. However, we can't merge now because some CI actions are not passing. Please, fix them. |
PeJetuz
force-pushed
the
jakarta_namespace
branch
from
24a658e to
08edaf7
Compare
|
@yegor256 fixed. Thanks! |
|
@PeJetuz not really :( |
PeJetuz
force-pushed
the
jakarta_namespace
branch
from
08edaf7 to
121aaff
Compare
|
I think I fixed it, but I'm not sure :( |
PeJetuz
force-pushed
the
jakarta_namespace
branch
from
121aaff to
0d3b6dc
Compare
|
@PeJetuz see the output of XCOP. Empty lines are prohibited in XML. |
PeJetuz
force-pushed
the
jakarta_namespace
branch
from
0d3b6dc to
e6ac430
Compare
|
@yegor256 |
|
@rultor merge |
|
@rultor release, tag is |
|
@PeJetuz thanks a lot, new version (0.68.0) released to Maven Central |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yegor256
Hi!
Is it ok? I want to add the jakarta namespace in takes 1307
Or these dependencies should be in takes only?