Timeouts #99

benhinssen · 2015-06-24T05:50:19Z

Fixes #91

Added the possibility to specify a timeout on the UrlConnection / HttpRequest, both in the ApacheRequest and the JdkRequest.

Please advise on my changes. If anything needs to be changed in order to be merged back, please let me know.

Thanks!

dmarkov · 2015-06-24T08:15:48Z

@benhinssen Thanks, let me find someone who can review this pull request

dmarkov · 2015-06-24T08:17:21Z

@pinaf review this one please

benhinssen · 2015-06-24T08:23:51Z

@dmarkov Thanks!

pinaf · 2015-06-24T16:20:59Z

@benhinssen there are a lot of checkstyle violations in the build logs. please fix those first.

benhinssen · 2015-06-25T08:41:12Z

@pinaf I made sure qulice returns only one error, and that is naming convention. I implemented that one can set both the read as connect timeout, so the parameters are called readTimeout and connectTimeout.
One solution is to refactor it to readtimeout and connecttimeout, but that feels like cheating.
Another is to drop support for read and connect timeout separately, and just have a timeout field.

Please advise and I will refactor accordingly.

pinaf · 2015-06-25T17:34:18Z

@benhinssen is this related to an open issue? If so, please make a reference to it on the first comment :)

pinaf · 2015-06-25T17:37:17Z

src/main/java/com/jcabi/http/request/ApacheRequest.java

-                    .setCircularRedirectsAllowed(false)
-                    .setRedirectsEnabled(false)
-                    .build()
+                    RequestConfig.custom()


@benhinssen indentation is broken here (too much)

pinaf · 2015-06-26T18:01:40Z

@benhinssen great! thanks!

yegor256 · 2015-06-29T04:33:07Z

@rultor merge

rultor · 2015-06-29T04:33:22Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2015-06-29T04:39:19Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 6min)

benhinssen · 2015-06-29T05:47:01Z

@yegor256 Thanks!

cvrebert · 2015-06-29T20:34:28Z

@yegor256 Will there be a new release with this soon?

yegor256 · 2015-06-29T23:20:28Z

@rultor release, tag is 1.11

rultor · 2015-06-29T23:20:35Z

@rultor release, tag is 1.11

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2015-06-29T23:29:25Z

@rultor release, tag is 1.11

@yegor256 Oops, I failed. You can see the full log here (spent 9min)

Downloading: https://oss.sonatype.org/content/groups/public/com/github/github/github-maven-core/0.10/github-maven-core-0.10.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.jar
Downloading: https://oss.sonatype.org/content/groups/public/org/eclipse/mylyn/github/org.eclipse.egit.github.core/3.1.0.201310021548-r/org.eclipse.egit.github.core-3.1.0.201310021548-r.jar
Downloading: https://oss.sonatype.org/content/groups/public/com/google/code/gson/gson/2.2.2/gson-2.2.2.jar
4/11 KB   
8/11 KB   
11/11 KB   


Downloaded: https://oss.sonatype.org/content/groups/public/com/github/github/github-maven-core/0.10/github-maven-core-0.10.jar (11 KB at 167.2 KB/sec)
4/185 KB   
8/185 KB   
12/185 KB   
16/185 KB   
20/185 KB   
24/185 KB   
28/185 KB   
29/185 KB   
33/185 KB   
37/185 KB   
38/185 KB   
42/185 KB   
46/185 KB   
46/185 KB   
50/185 KB   
54/185 KB   
58/185 KB   
62/185 KB   
66/185 KB   

70/185 KB   
74/185 KB   
78/185 KB   
82/185 KB   
86/185 KB   
90/185 KB   
94/185 KB   
98/185 KB   
102/185 KB   
106/185 KB   
110/185 KB   
114/185 KB   
118/185 KB   
122/185 KB   
126/185 KB   
130/185 KB   
134/185 KB   
138/185 KB   
142/185 KB   
146/185 KB   
150/185 KB   
154/185 KB   
158/185 KB   
162/185 KB   
166/185 KB   
170/185 KB   
174/185 KB   
178/185 KB   
182/185 KB   
185/185 KB   

Downloaded: https://oss.sonatype.org/content/groups/public/com/google/code/gson/gson/2.2.2/gson-2.2.2.jar (185 KB at 3697.0 KB/sec)
Downloading: http://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.jar
Downloading: http://repo.maven.apache.org/maven2/org/eclipse/mylyn/github/org.eclipse.egit.github.core/3.1.0.201310021548-r/org.eclipse.egit.github.core-3.1.0.201310021548-r.jar
4/222 KB     
8/222 KB   
12/222 KB   
16/222 KB   
20/222 KB   
24/222 KB   
28/222 KB   
32/222 KB   
36/222 KB   
40/222 KB   
44/222 KB   
48/222 KB   
52/222 KB   
56/222 KB   
60/222 KB   
64/222 KB   
68/222 KB   
72/222 KB   
76/222 KB   
80/222 KB   
84/222 KB   
88/222 KB   
92/222 KB   
96/222 KB   
100/222 KB   
104/222 KB   
108/222 KB   
112/222 KB   
116/222 KB   
120/222 KB   
124/222 KB   
128/222 KB   
132/222 KB   
136/222 KB   
140/222 KB   
144/222 KB   
148/222 KB   
152/222 KB   

156/222 KB   
160/222 KB   
164/222 KB   
168/222 KB   
172/222 KB   
176/222 KB   
180/222 KB   
184/222 KB   
188/222 KB   
192/222 KB   
196/222 KB   
200/222 KB   
204/222 KB   
208/222 KB   
212/222 KB   
216/222 KB   
220/222 KB   
222/222 KB   

Downloaded: http://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.jar (222 KB at 9219.8 KB/sec)
Downloading: https://repo.eclipse.org/content/repositories/egit-releases/org/eclipse/mylyn/github/org.eclipse.egit.github.core/3.1.0.201310021548-r/org.eclipse.egit.github.core-3.1.0.201310021548-r.jar
4/217 KB     
8/217 KB   
12/217 KB   
16/217 KB   
20/217 KB   
24/217 KB   
28/217 KB   
31/217 KB   
32/217 KB   
36/217 KB   
40/217 KB   
44/217 KB   
48/217 KB   
52/217 KB   
56/217 KB   
60/217 KB   
64/217 KB   
68/217 KB   
72/217 KB   
76/217 KB   
79/217 KB   
83/217 KB   
87/217 KB   
91/217 KB   
95/217 KB   
99/217 KB   
103/217 KB   
107/217 KB   
111/217 KB   
115/217 KB   
118/217 KB   
122/217 KB   
126/217 KB   
130/217 KB   
134/217 KB   
138/217 KB   
142/217 KB   
146/217 KB   
150/217 KB   
154/217 KB   
157/217 KB   
161/217 KB   
165/217 KB   
169/217 KB   
173/217 KB   
177/217 KB   
181/217 KB   
185/217 KB   
189/217 KB   
193/217 KB   
197/217 KB   
201/217 KB   
204/217 KB   
208/217 KB   
212/217 KB   
216/217 KB   
217/217 KB   

Downloaded: https://repo.eclipse.org/content/repositories/egit-releases/org/eclipse/mylyn/github/org.eclipse.egit.github.core/3.1.0.201310021548-r/org.eclipse.egit.github.core-3.1.0.201310021548-r.jar (217 KB at 483.9 KB/sec)
[INFO] Creating 295 blobs
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2015-06-29T23:28:15+00:00
[INFO] Final Memory: 57M/456M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.github:site-maven-plugin:0.10:site (default) on project jcabi-http: Error creating blob: You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. (403) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.github.github:site-maven-plugin:0.10:site (default) on project jcabi-http: Error creating blob: You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. (403)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating blob: You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. (403)
    at com.github.maven.plugins.site.SiteMojo.createBlob(SiteMojo.java:293)
    at com.github.maven.plugins.site.SiteMojo.execute(SiteMojo.java:356)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
Caused by: org.eclipse.egit.github.core.client.RequestException: You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. (403)
    at org.eclipse.egit.github.core.client.GitHubClient.createException(GitHubClient.java:552)
    at org.eclipse.egit.github.core.client.GitHubClient.sendJson(GitHubClient.java:643)
    at org.eclipse.egit.github.core.client.GitHubClient.post(GitHubClient.java:757)
    at org.eclipse.egit.github.core.service.DataService.createBlob(DataService.java:115)
    at com.github.maven.plugins.site.SiteMojo.createBlob(SiteMojo.java:289)
    ... 22 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

cvrebert · 2015-06-29T23:34:16Z

Error creating blob: You have triggered an abuse detection mechanism. Please wait a few minutes before you try again. (403)

yegor256 · 2015-06-29T23:36:03Z

@rultor release, tag is 1.11

rultor · 2015-06-29T23:37:10Z

@rultor release, tag is 1.11

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2015-06-29T23:45:59Z

@rultor release, tag is 1.11

@yegor256 Done! FYI, the full log is here (took me 9min)

dmarkov · 2015-06-30T07:35:51Z

@pinaf I added 28 mins to your account, many thanks for working with the project! The completion time here was AP-26D81886G9735604Y.; you're getting extra minutes here (c=13); added +28 to your rating, now it is equal to +6643

dmarkov · 2015-06-30T07:36:07Z

@rultor deploy pls

rultor · 2015-06-30T07:36:19Z

@rultor deploy pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor · 2015-06-30T07:42:00Z

@rultor deploy pls

@dmarkov Done! FYI, the full log is here (took me 6min)

Ben Hinssen added 4 commits May 27, 2015 09:45

implement timeouts for ApacheRequest and JdkRequest

d610c66

Also use timeout when using wires

a1b5ec1

set groupId for own fork

dcde211

Set groupId to local one for now

003ff4e

dmarkov added CR @pinaf labels Jun 24, 2015

dmarkov assigned pinaf Jun 24, 2015

dmarkov added the 15 mins label Jun 24, 2015

Ben Hinssen added 3 commits June 25, 2015 09:29

implement timeouts for ApacheRequest and JdkRequest

152f853

Fix formatting and checkstyle issues.

e4c4d4f

Fix pom file

2e26235

pinaf reviewed Jun 25, 2015
View reviewed changes

rultor merged commit ca83397 into jcabi:master Jun 29, 2015

benhinssen deleted the timeouts branch June 29, 2015 05:47

benhinssen mentioned this pull request Jun 29, 2015

No timeouts #91

Closed

dmarkov added CR labels Jun 29, 2015

cvrebert mentioned this pull request Jun 29, 2015

Timeout GitHub API requests twbs/savage#20

Open

yegor256 pushed a commit that referenced this pull request Jun 29, 2015

#99 ignore site-deploy errors

e8b703e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timeouts #99

Timeouts #99

benhinssen commented Jun 24, 2015

dmarkov commented Jun 24, 2015

dmarkov commented Jun 24, 2015

benhinssen commented Jun 24, 2015

pinaf commented Jun 24, 2015

benhinssen commented Jun 25, 2015

pinaf commented Jun 25, 2015

pinaf Jun 25, 2015

pinaf commented Jun 26, 2015

yegor256 commented Jun 29, 2015

rultor commented Jun 29, 2015

rultor commented Jun 29, 2015

benhinssen commented Jun 29, 2015

cvrebert commented Jun 29, 2015

yegor256 commented Jun 29, 2015

rultor commented Jun 29, 2015

rultor commented Jun 29, 2015

cvrebert commented Jun 29, 2015

yegor256 commented Jun 29, 2015

rultor commented Jun 29, 2015

rultor commented Jun 29, 2015

dmarkov commented Jun 30, 2015

dmarkov commented Jun 30, 2015

rultor commented Jun 30, 2015

rultor commented Jun 30, 2015

Timeouts #99

Timeouts #99

Conversation

benhinssen commented Jun 24, 2015

dmarkov commented Jun 24, 2015

dmarkov commented Jun 24, 2015

benhinssen commented Jun 24, 2015

pinaf commented Jun 24, 2015

benhinssen commented Jun 25, 2015

pinaf commented Jun 25, 2015

pinaf Jun 25, 2015

Choose a reason for hiding this comment

pinaf commented Jun 26, 2015

yegor256 commented Jun 29, 2015

rultor commented Jun 29, 2015

rultor commented Jun 29, 2015

benhinssen commented Jun 29, 2015

cvrebert commented Jun 29, 2015

yegor256 commented Jun 29, 2015

rultor commented Jun 29, 2015

rultor commented Jun 29, 2015

cvrebert commented Jun 29, 2015

yegor256 commented Jun 29, 2015

rultor commented Jun 29, 2015

rultor commented Jun 29, 2015

dmarkov commented Jun 30, 2015

dmarkov commented Jun 30, 2015

rultor commented Jun 30, 2015

rultor commented Jun 30, 2015