Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FakeRequest doesn't allow to return different body depending on the url #82

Closed
dmzaytsev opened this issue Apr 22, 2015 · 8 comments
Closed

Comments

@dmzaytsev
Copy link

FakeRequest doesn't allow to return different RequestBody depending on the url.
Needs to add new methods to FakeRequest

    public FakeRequest withBody(final String regexp, final String text) {
    }

    public FakeRequest withBody(final String regexp, final byte[] body) {
    } 
@dmzaytsev
Copy link
Author

@yegor256 @dmarkov could you please assign this task to me?

dmzaytsev added a commit to dmzaytsev/jcabi-http that referenced this issue Apr 22, 2015
@yegor256
Copy link
Member

@dmarkov please assign @dmzaytsev to this task

@dmarkov
Copy link

dmarkov commented Apr 24, 2015

@dmzaytsev this task will get someone's attention soon

@dmarkov
Copy link

dmarkov commented Apr 24, 2015

@dmzaytsev thanks for the ticket, your account was topped for 15 mins, payment 55972701

@dmarkov
Copy link

dmarkov commented Apr 24, 2015

@dmarkov please assign @dmzaytsev to this task

@yegor256 OK @dmzaytsev please start, the task is yours

@dmzaytsev
Copy link
Author

@dmarkov the PR here #83 please find someone to review. Thanks.

dmzaytsev added a commit to dmzaytsev/jcabi-http that referenced this issue Apr 27, 2015
dmzaytsev added a commit to dmzaytsev/jcabi-http that referenced this issue Apr 27, 2015
dmzaytsev added a commit to dmzaytsev/jcabi-http that referenced this issue Apr 28, 2015
@dmzaytsev
Copy link
Author

@dmarkov I am closing the task
the reason:

yegor256 commented an hour ago
@dmzaytsev I would just close it. no need to develop all this in jcabi-http if we have Takes

@dmarkov
Copy link

dmarkov commented May 5, 2015

@dmzaytsev I added 30 mins to your account, many thanks for working with the project! The completion time here was 56747190.. +30 to your rating, your total score is +1182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants