Deprecation and sanity improvements #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `isSet` is deprecated and an alias for `is_set`. Use that instead to avoid deprecation warnings. Signed-off-by: Olliver Schinagl <[email protected]>
The path replacement function tries to remove `/se` from the full path. However, if the path already contains `/se`, such as for example in `/solaredge/semonitor/se/msg.py` the path gets completely messed up. Instead, by using python's `removesuffix`, we get what we wanted. Signed-off-by: Olliver Schinagl <[email protected]>
ericbuehl
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small commits to improve quality of life.
Python 3.10 complains about
isSetbeing deprecated, there's a drop-in replacement in the form ofis_set.The magic to store the hardcoded last0503 message fails if the path also contains
/sealready. We can do better here. Even better would have been to store this in/tmpor in/var/lib/semonitor, as storing it in the (distribution) source directory is a bit weird.