remove file from pre-defined appenders.

file name is required. let users to setup everything
jbudz · Feb 12, 2020 · 96f1edb · 96f1edb
1 parent bf3215a
commit 96f1edb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/src/core/server/logging/logging_config.test.ts b/src/core/server/logging/logging_config.test.ts
@@ -59,7 +59,7 @@ test('`getLoggerContext()` returns correct joined context name.', () => {
 test('correctly fills in default config.', () => {
   const configValue = new LoggingConfig(config.schema.validate({}));
 
-  expect(configValue.appenders.size).toBe(3);
+  expect(configValue.appenders.size).toBe(2);
 
   expect(configValue.appenders.get('default')).toEqual({
     kind: 'console',
@@ -69,10 +69,6 @@ test('correctly fills in default config.', () => {
     kind: 'console',
     layout: { kind: 'pattern', highlight: true },
   });
-  expect(configValue.appenders.get('file')).toEqual({
-    kind: 'file',
-    layout: { kind: 'pattern', highlight: false },
-  });
 });
 
 test('correctly fills in custom `appenders` config.', () => {
@@ -83,16 +79,11 @@ test('correctly fills in custom `appenders` config.', () => {
           kind: 'console',
           layout: { kind: 'pattern' },
         },
-        file: {
-          kind: 'file',
-          layout: { kind: 'pattern' },
-          path: 'path',
-        },
       },
     })
   );
 
-  expect(configValue.appenders.size).toBe(3);
+  expect(configValue.appenders.size).toBe(2);
 
   expect(configValue.appenders.get('default')).toEqual({
     kind: 'console',
@@ -103,12 +94,6 @@ test('correctly fills in custom `appenders` config.', () => {
     kind: 'console',
     layout: { kind: 'pattern' },
   });
-
-  expect(configValue.appenders.get('file')).toEqual({
-    kind: 'file',
-    layout: { kind: 'pattern' },
-    path: 'path',
-  });
 });
 
 test('correctly fills in default `loggers` config.', () => {

diff --git a/src/core/server/logging/logging_config.ts b/src/core/server/logging/logging_config.ts
@@ -140,13 +140,6 @@ export class LoggingConfig {
         layout: { kind: 'pattern', highlight: true },
       } as AppenderConfigType,
     ],
-    [
-      'file',
-      {
-        kind: 'file',
-        layout: { kind: 'pattern', highlight: false },
-      } as AppenderConfigType,
-    ],
   ]);
 
   /**