forked from http-rs/tide
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handler middleware with error storage #1
Closed
Fishrock123
wants to merge
272
commits into
jbr:master
from
Fishrock123:error-handler-middleware-with-error-storage
Closed
Error handler middleware with error storage #1
Fishrock123
wants to merge
272
commits into
jbr:master
from
Fishrock123:error-handler-middleware-with-error-storage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to use the intermediate Service struct making it easier to use Tide's Server.
Now that Service is no longer a thing, we no longer need a submodule to contain it.
Since Server now implement HttpService we no longer need Server::into_http_service
Enable use of `?` in Endpoint
Mentions `async-std` and its `features = ["attributes"]` clearly.
and use it in the Redirect endpoint
Remove intermediate Service struct
This depends on http-rs#414 Add serve_dir method to Route Update serve_dir.rs Adjust methods so body can correctly be sent along tweak static file serving simplify internals cargo fmt & fix tests fix all tests cargo fmt Fix merge conflicts with master undo bonus changes Fix static path prefix stripping err
Static files
…-features-attributes Documentation: Add "Getting Started" section to Readme and lib.rs.
Add Response::redirect
Now supports both permanent and temporary redirects, and updated all vocabulary in Tide to be consistent with one another.
Doc fixes for lib.rs
Add redirect submodule
Adds log submodule
Introduces a new cookies submodule, and axes several unused types. Thanks!
Co-authored-by: Jeremiah Senkpiel <[email protected]>
Bring response in line with http-types
Signed-off-by: Marc-Antoine Perennou <[email protected]>
drop unused serde_qs dependency
Uncomment and fix tests/response
Delete CHANGELOG.md
because apparently cookie-0.14.1 uses a feature flag in docs
Closing in favor of http-rs@a1cb10e on http-rs#570 |
jbr
pushed a commit
that referenced
this pull request
Aug 10, 2021
change readme so the text isn't all wonky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is http-rs#549 rebased on top of http-rs/http-types#174 & http-rs#570.
Presently does not compile correctly, which makes me a bit concerned about the plan with those two PRs.