Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Narayana to 6.0.1.Final and Quarkus to 3.0.0.Final #40

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Apr 25, 2023

No description provided.

@zhfeng
Copy link
Contributor Author

zhfeng commented Apr 25, 2023

I have to add org.slf4j:slf4j-api in the pom.xml explicitly because it was introduced by narayana-bom which has a different version and test scope. Without it, there is WARN message when starting the coordinator image.

SLF4J: The requested version 2.0.6 by your slf4j binding is not compatible with [1.6, 1.7]
SLF4J: See http://www.slf4j.org/codes.html#version_mismatch for further details.

I also open https://issues.redhat.com/browse/JBTM-3779 to move out such artifacts with test scope in narayana-bom.

Copy link
Member

@mmusgrov mmusgrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xstefank can we merge this one and push a new image in order to fix the issue reported over at quarkusio/quarkus#32922 (comment)

Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically, we don't have such delays but I wanted to write a GH action before we merge this. But since this has now priority, I verified manually locally.

@xstefank xstefank merged commit 1f8fcc7 into jbosstm:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants