Defer creating new PoolThreadNode until after task is run

jbossas · Sep 26, 2024 · 958a3bb · 958a3bb
1 parent 2cc0ffa
commit 958a3bb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/org/jboss/threads/EnhancedQueueExecutor.java b/src/main/java/org/jboss/threads/EnhancedQueueExecutor.java
@@ -1601,8 +1601,6 @@ public void run() {
                 } else if (node == nextPoolThreadNode) {
                     // pool thread node was added
                     final PoolThreadNode newNode = nextPoolThreadNode;
-                    // nextPoolThreadNode has been added to the queue, a new node is required for next time.
-                    nextPoolThreadNode = new PoolThreadNode(currentThread);
                     // at this point, we are registered into the queue
                     long start = System.nanoTime();
                     long elapsed = 0L;
@@ -1613,6 +1611,8 @@ public void run() {
                             if (newNode.compareAndSetTask(task, ACCEPTED)) {
                                 // we have a task to run, so run it and then abandon the node
                                 task.run();
+                                // nextPoolThreadNode has been added to the queue, a new node is required for next time.
+                                nextPoolThreadNode = new PoolThreadNode(currentThread);
                                 // rerun outer
                                 continue processingQueue;
                             }