Testsuite improvements - make the tests repeateable without clean task #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to what is actually needed
…get/ dir Currently some of the tests fail when they are run repeatedly without running the clean task. The core reason usually is that by default the provisining is skipped when the server directory already exists, and so the code that was expected to be executed is not executed.
jamezp
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bit debatable "improvement", please close the PR if it doesn't suit you.
Currently some of the tests fail when they are run repeatedly without running the clean task. I.e. running following sequence will result in test failures:
The core reason usually is that by default the provisioning is terminated early, when the server directory already exists (from the previous test execution), and so the expected provisioning failure for instance is not triggered.
I set overwrite-provisioned-server to true in affected test pom files to enforce overriding the old installation. It could also be solved by cleaning the installation dir in some @ Before method.