[ISSUE-205] bump git api version to 1.111

jboss-set · May 18, 2020 · b7c5004 · b7c5004
1 parent 321084e
commit b7c5004
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/github/pom.xml b/github/pom.xml
@@ -35,7 +35,7 @@
         <dependency>
             <groupId>com.squareup.okhttp</groupId>
             <artifactId>okhttp-urlconnection</artifactId>
-            <version>2.7.5</version>
+            <version>${com.squareup.okhttp.okhttp-urlconnection.version}</version>
         </dependency>
         <dependency>
             <groupId>org.jboss.set</groupId>
@@ -44,7 +44,7 @@
         <dependency>
             <groupId>org.kohsuke</groupId>
             <artifactId>github-api</artifactId>
-            <version>1.92</version>
+            <version>${org.kohsuke.github-api.version}</version>
         </dependency>
     </dependencies>
 </project>
diff --git a/...c/main/java/org/jboss/set/aphrodite/repository/services/github/AbstractGithubService.java b/...c/main/java/org/jboss/set/aphrodite/repository/services/github/AbstractGithubService.java
@@ -64,15 +64,10 @@ public boolean init(RepositoryConfig config) {
         if (!parentInitiated)
             return false;
 
-        try {
-            if (github != null && github.isCredentialValid()) {
-                return true;
-            } else {
-                return commonGithubInit(config);
-            }
-        } catch (IOException e) {
-            Utils.logException(LOG, "Authentication failed for username: " + config.getUsername(), e);
-            return false;
+        if (github != null && github.isCredentialValid()) {
+            return true;
+        } else {
+            return commonGithubInit(config);
         }
     }
 

diff --git a/pom.xml b/pom.xml
@@ -103,6 +103,8 @@
         <junit.version>4.12</junit.version>
         <org.mockito.version>1.10.19</org.mockito.version>
         <org.wildfly.checkstyle-config.version>1.0.4.Final</org.wildfly.checkstyle-config.version>
+        <org.kohsuke.github-api.version>1.111</org.kohsuke.github-api.version>
+        <com.squareup.okhttp.okhttp-urlconnection.version>2.7.5</com.squareup.okhttp.okhttp-urlconnection.version>
     </properties>