This repository has been archived by the owner on May 4, 2018. It is now read-only.
enabled to use CCT modules from cct dir next to the image descriptor #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dogen CCT plugin can now inject CCT modules from directory next to image descriptor as follows: if you have directory structure like: ``` image.yaml cct/module1 cct/module2 ``` Dogen CCT plugin will make module1 and modul2 available in target directory for CCT to use them. If cct/module1 is symbolink link its target directory gets copied (symlink is followed).
This was referenced Jul 3, 2017
goldmann
reviewed
Jul 3, 2017
dogen/plugins/cct.py
Outdated
| @@ -91,6 +91,14 @@ def prepare(self, cfg): | |||
|
|
|||
| os.makedirs(target_modules_dir) | |||
|
|
|||
| local_modules_dir = os.path.join(os.path.dirname(self.descriptor),'cct') | |||
| self.log.debug('Found existing modules in directory: %s' % local_modules_dir) | |||
There was a problem hiding this comment.
I would give it more visibility by using info log level.
There was a problem hiding this comment.
I'm logging real modules name if its get copied - this is IMHO ok as Debug its only telling some convention.
dogen/plugins/cct.py
Outdated
| self.log.debug('Found existing modules in directory: %s' % local_modules_dir) | ||
| if os.path.exists(local_modules_dir): | ||
| for module in os.listdir(local_modules_dir): | ||
| self.log.info('Using cached module %s.' % module) |
There was a problem hiding this comment.
And remove the dot at the end :)
goldmann
reviewed
Jul 3, 2017
dogen/plugins/cct.py
Outdated
| if os.path.exists(local_modules_dir): | ||
| for module in os.listdir(local_modules_dir): | ||
| module_path = os.path.join(local_modules_dir, module) | ||
| self.log.info('Using cached module "%s" from path:"%s"' % (module, module_path)) |
There was a problem hiding this comment.
And in general - we use single quote to quote things in strings. You did it other way.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dogen CCT plugin can now inject CCT modules from directory next to
image descriptor as follows:
if you have directory structure like:
Dogen CCT plugin will make module1 and modul2 available in target
directory for CCT to use them.
If cct/module1 is symbolink link its target directory gets copied (symlink
is followed).