Added target framework to netstandard2.0 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I...don't understand how this compiles. The docs say
I'll do some more digging but if it's working with |
|
Welp it gets pulled in with the Microsoft.Bcl.AsyncInterfaces package (which I did not know existed). Derp. We can just target |
jbogard
requested changes
Jan 17, 2023
src/MediatR/MediatR.csproj
Outdated
| @@ -4,7 +4,7 @@ | |||
| <Authors>Jimmy Bogard</Authors> | |||
| <Description>Simple, unambitious mediator implementation in .NET</Description> | |||
| <Copyright>Copyright Jimmy Bogard</Copyright> | |||
| <TargetFrameworks>netstandard2.1</TargetFrameworks> | |||
| <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> | |||
There was a problem hiding this comment.
Evidently this can be JUST netstandard2.0.
*RequestExceptionHandlerState.cs *IStreamRequestHandler.cs
*Microsoft.Extensions.DependencyInjection.Abstractions 7.0.0 *MinVer 4.2.0
jbogard
approved these changes
Jan 18, 2023
|
Unfortunately I have some problems compiling the project, i get the following message: |
jbogard
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider adding netstandard2.0 as a target framework if you can.