-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Auto Registration of Generic Handlers OPT-IN #1057
Conversation
- remove logic - reomove tests
Is this PR now just removing the protections from the registration process to make errors go away? Won't this now potentially cause users to end up having a lot of unwanted service registrations and potentially timeouts happening during application startup as the feature has been implemented opt-out instead of opt-in? In my opinion the whole feature should either be removed or then the feature should be made opt-in to make sure that no one ends up getting this enabled by default by just upgrading to a newer minor version. As already stated before, this is anyway too late at this point as |
Yes it could result in too many registrations. I don't mind making it opt
in either.
…On Sun, Aug 4, 2024, 6:47 AM Henri Nieminen ***@***.***> wrote:
Is this PR now just removing the protections from the registration process
to make errors go away? Won't this now potentially cause users to end up
having a lot of unwanted service registrations and potentially timeouts
happening during application startup as the feature has been implemented
opt-out instead of opt-in?
In my opinion the whole feature should either be removed or then the
feature should be made opt-in to make sure that no one ends up getting this
enabled by default by just upgrading to a newer minor version. As already
stated before, this is anyway too late at this point as 12.3.0 and newer
versions have already been released, but the current approach should have
been a major version increment.
—
Reply to this email directly, view it on GitHub
<#1057 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACL2QUUW5PD6S6CJLOZKI2LZPYWHXAVCNFSM6AAAAABL5OIKNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGU2DSNZQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Ok, I have made the feature Opt-In. |
This bit me pretty hard when I added |
Hi, any chance of adding this and releasing the nuget package? After upgrading to version 12.4, we had a few interesting hours to investigate what the ... going on, |
Same here. Installed MassTransit and promptly lost a day tracking it. Backed down a version to fix it. |
Ugh so I think I'll push a version with this behavior opt-in but I want to tackle this much differently. Manually registering and scanning isn't really feasible. |
This is a direct fix for many people's issues regarding the enforcement of constraints for generic request handers having more than two generic type parameters.
Direct fix for: #1055 , #1038
@jbogard I have made this pr so that you can decide what you want to do. Either remove the feature completely or make it Opt-In until we can implement a better resolution strategy.