Merge pull request #801 from sunero4/feat/static-lambdas

Added static modifier for lambdas where applicable in Mediatr project.
jbogard · Nov 20, 2022 · 054ccc1 · 054ccc1
2 parents d2f166e + 205172d
commit 054ccc1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/src/MediatR/Internal/HandlersOrderer.cs b/src/MediatR/Internal/HandlersOrderer.cs
@@ -15,12 +15,12 @@ public static IList<object> Prioritize<TRequest>(IList<object> handlers, TReques
         }
 
         var requestObjectDetails = new ObjectDetails(request);
-        var handlerObjectsDetails = handlers.Select(s => new ObjectDetails(s)).ToList();
+        var handlerObjectsDetails = handlers.Select(static s => new ObjectDetails(s)).ToList();
 
         var uniqueHandlers = RemoveOverridden(handlerObjectsDetails).ToArray();
         Array.Sort(uniqueHandlers, requestObjectDetails);
 
-        return uniqueHandlers.Select(s => s.Value).ToList();
+        return uniqueHandlers.Select(static s => s.Value).ToList();
     }
 
     private static IEnumerable<ObjectDetails> RemoveOverridden(IList<ObjectDetails> handlersData)
@@ -45,6 +45,6 @@ private static IEnumerable<ObjectDetails> RemoveOverridden(IList<ObjectDetails>
             }
         }
 
-        return handlersData.Where(w => !w.IsOverridden);
+        return handlersData.Where(static w => !w.IsOverridden);
     }
 }
diff --git a/src/MediatR/Mediator.cs b/src/MediatR/Mediator.cs
@@ -148,7 +148,7 @@ public IAsyncEnumerable<TResponse> CreateStream<TResponse>(IStreamRequest<TRespo
             {
                 var requestInterfaceType = requestTypeKey
                     .GetInterfaces()
-                    .FirstOrDefault(i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(IStreamRequest<>));
+                    .FirstOrDefault(static i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(IStreamRequest<>));
                 var isValidRequest = requestInterfaceType != null;
 
                 if (!isValidRequest)

diff --git a/src/MediatR/Pipeline/RequestExceptionActionProcessorBehavior.cs b/src/MediatR/Pipeline/RequestExceptionActionProcessorBehavior.cs
@@ -35,9 +35,9 @@ public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TRe
 
             var actionsForException = exceptionTypes
                 .SelectMany(exceptionType => GetActionsForException(exceptionType, request))
-                .GroupBy(actionForException => actionForException.Action.GetType())
-                .Select(actionForException => actionForException.First())
-                .Select(actionForException => (MethodInfo: GetMethodInfoForAction(actionForException.ExceptionType), actionForException.Action))
+                .GroupBy(static actionForException => actionForException.Action.GetType())
+                .Select(static actionForException => actionForException.First())
+                .Select(static actionForException => (MethodInfo: GetMethodInfoForAction(actionForException.ExceptionType), actionForException.Action))
                 .ToList();
 
             foreach (var actionForException in actionsForException)

diff --git a/src/MediatR/Pipeline/RequestExceptionProcessorBehavior.cs b/src/MediatR/Pipeline/RequestExceptionProcessorBehavior.cs
@@ -37,9 +37,9 @@ public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TRe
 
             var handlersForException = exceptionTypes
                 .SelectMany(exceptionType => GetHandlersForException(exceptionType, request))
-                .GroupBy(handlerForException => handlerForException.Handler.GetType())
-                .Select(handlerForException => handlerForException.First())
-                .Select(handlerForException => (MethodInfo: GetMethodInfoForHandler(handlerForException.ExceptionType), handlerForException.Handler))
+                .GroupBy(static handlerForException => handlerForException.Handler.GetType())
+                .Select(static handlerForException => handlerForException.First())
+                .Select(static handlerForException => (MethodInfo: GetMethodInfoForHandler(handlerForException.ExceptionType), handlerForException.Handler))
                 .ToList();
 
             foreach (var handlerForException in handlersForException)

diff --git a/src/MediatR/Wrappers/NotificationHandlerWrapper.cs b/src/MediatR/Wrappers/NotificationHandlerWrapper.cs
@@ -22,7 +22,7 @@ public override Task Handle(INotification notification, ServiceFactory serviceFa
     {
         var handlers = serviceFactory
             .GetInstances<INotificationHandler<TNotification>>()
-            .Select(x => new Func<INotification, CancellationToken, Task>((theNotification, theToken) => x.Handle((TNotification)theNotification, theToken)));
+            .Select(static x => new Func<INotification, CancellationToken, Task>((theNotification, theToken) => x.Handle((TNotification)theNotification, theToken)));
 
         return publish(handlers, notification, cancellationToken);
     }