Fix navigation.tabs for non-leaf pages #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbms
force-pushed
the
fix-navigation-tabs
branch
from
8c41c40 to
bc9fec9
Compare
Previously, when using navigation.tabs on non-leaf pages, the integrated TOC used for "layered" (mobile) navigation would incorrectly display as well. The fix in 87d87f9 was was not sufficient due to a CSS precedence issue, which is now corrected by using `!important`.
jbms
force-pushed
the
fix-navigation-tabs
branch
from
bc9fec9 to
7be2c56
Compare
2bndy5
approved these changes
Jan 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 68 68
Lines 8678 8678
=======================================
Hits 7127 7127
Misses 1551 1551 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using navigation.tabs on non-leaf pages, the integrated TOC used for "layered" (mobile) navigation would incorrectly display as well. The fix in 87d87f9 was was not sufficient due to a CSS precedence issue, which is now corrected by using
!important.