-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme does not work with rST Vscode Extension #163
Comments
Can you post anything that tells us why the font is causing the extension to crash? If it is a problem with the path to the fonts not being relative to the sphinx-build output, then you can use the config option |
Unfortunately the extension does not seem to write much about this problem on the console even with debug log level.
sphinx_immaterial_external_resource_cache_dir worked well with local build but not with the build triggered by the extension, There is some suggestion by the Esbonio developers here |
Maybe it is notable to say that I am using a VsCode DevContainer. But most other themes work fine with this setup and Esbonio. |
The Esbonio language server runs its own asyncio loop context when it invokes the Sphinx code. This causes the asyncio.run() call to complain since it's already being run in the same thread. Since we're already running a set of threads here using PoolExecutor, we can run one more thread which runs the asyncio.run() context in a separate thread. This mitigates the interoperability issue with the Esbonio language server at the cost of an additional thread, and at the cost of blocking the coroutine loop within the Esbonio language server for the closing of the download set. (See also swyddfa/esbonio#451)
The Esbonio language server runs its own asyncio loop context when it invokes the Sphinx code. This causes the asyncio.run() call to complain since it's already being run in the same thread. Since we're already running a set of threads here using PoolExecutor, we can run one more thread which runs the asyncio.run() context in a separate thread. This mitigates the interoperability issue with the Esbonio language server at the cost of an additional thread, and at the cost of blocking the coroutine loop within the Esbonio language server for the closing of the download set. (See also swyddfa/esbonio#451)
Solution released in v0.11.4 |
I really like the immaterial theme, but it does not work with rST VsCode Extension. The problem is with the language server (Esbonio) used by the extension that it crashes with the async Google font download.
I did not find a way to turn off the font download. It would be nice, if the font download is made optional.
The text was updated successfully, but these errors were encountered: