ofx: try actual specified lower bound before binary searching to find earliest available start date #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… earliest available start date The ofx source tries to guess when data for an account begins. It has the user specify a minimum start date as an anchor, and then uses binary search to find the earliest date since then which generates a nonempty response from the institution. If the institution actually has data from the minimum start date, this results in a rather silly search—and, in fact, the binary search as implemented never tries the lower bound of the range at all (the interval being searched is open at both ends), so if a user specifies the actual first day for which they have data as min_start_date, finance-dl would always miss that first day. Given that the user knowing when their data starts is at least a plausible case, we should try it before resorting to cleverness; this change makes us do so.
Zburatorul
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ofx source tries to guess when data for an account begins. It has the user
specify a minimum start date as an anchor, and then uses binary search to find
the earliest date since then which generates a nonempty response from the
institution.
If the institution actually has data from the minimum start date, this results
in a rather silly search—and, in fact, the binary search as implemented never
tries the lower bound of the range at all (the interval being searched is open
at both ends), so if a user specifies the actual first day for which they have
data as min_start_date, finance-dl would always miss that first day. Given
that the user knowing when their data starts is at least a plausible case, we
should try it before resorting to cleverness; this change makes us do so.