[Amazon] Multi-Language Support

[moritzj29]

Hello,

I took PR #48 by @Marvin182 and addressed the comments of @Zburatorul from the code review to make this very valuable contribution mergeable:

• include upstream code changes (Amazon fresh)
• revert back to the old way of looking for invoice links by looking for orderID

I tested this with my amazon.de account and it works very well. All credit goes out to @Marvin182 for implementing this in the first place!

I'm happy for your comments!

PS: I'm also working on the corresponding beancount-import module over here: jbms/beancount-import#144

[moritzj29]

found some flaws... I will get back working on this...

[moritzj29]

some background to better understand the changes in the code (I find this quite helpful since we all only know our "own" amazon pages...):

From the code I assume that for amazon.com/.uk the orders overview look something like this with the Invoice button linking directly to the order_summary which we want to download:

For amazon.de the page is different, since Invoice always opens a menu. This menu is loaded on demand, therefore a click is required to retrieve the link. (This is probably due to the fact that invoices need to be in an unalterable format like PDF in Germany, so HTML is not sufficient as official invoice.)

In the code I added an additional per-domain flag, indicating if the order_summary link is hidden in the submenu or not. Depending on the flag, the link is retrieved the old way (master branch) or the new way as proposed in #48.

It would be great if someone with a .com or .uk account could test the code to make sure everything works out.

[moritzj29]

I renamed this to make it more clear that is does not toggle the download of digital invoices in all cases (only for .com!). It's basically a flag which says if there is a separate digital orders list on the amazon website or not.

[moritzj29]

I updated the PR to include the upstream changes to the Amazon source and cleaned up the history. It would be great if someone could have a look at it! @Zburatorul you appear to be most involved at the moment?

If there is no interest in merging this here, just tell me. I will maintain it in my own fork then.

[moritzj29]

awesome! thanks @jbms !

[Zburatorul]

@Marvin182, @moritzj29, thanks for the contributions and for getting this over the line!

[Zburatorul]

@moritzj29, there's a bug for digital orders on line 471. Undefined variable.

[moritzj29]

Oh sorry,self.domain.digital_orders_text must be self.domain.digital_orders_menu_text . I will submit a fix today. Unfortunately I had no possibility to test run it on .com…

[Zburatorul]

Also, can you turn this into a logger.debug instead please. It prints on every single order and pollutes the screen.

[moritzj29]

ok, sure