Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ] in converting ocean variables example + add targets for Documenter and Coverage #65

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Missing ] in converting ocean variables example + add targets for Documenter and Coverage #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39d3591
Missing ]
jbisits Jun 20, 2023
517362c
Update targets for PR
jbisits Jun 20, 2023
efa9142
Update Project.toml
jbisits Jun 20, 2023
1f9c5a0
add NCDatasets.jl for Rasters.jl v0.8
jbisits Jun 20, 2023
9e04713
Add to `docs` toml and fix typo
jbisits Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
GibbsSeaWater = "9a22fb26-0b63-4589-b28e-8f9d0b5c3d05"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
MakieCore = "20f20a25-4f0e-4fdf-b5d1-57303727442b"
NCDatasets = "85f8d34a-cbdd-5861-8df4-14fed0d494ab"
Rasters = "a3a2b9e3-a471-40c9-b274-f788e487c689"
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
Expand All @@ -26,7 +27,9 @@ StatsBase = "0.33, 0.34"
julia = "1.6"

[extras]
Coverage = "a2441757-f6aa-5fb2-8edb-039e3f45d037"
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test"]
test = ["Test", "Documenter", "Coverage"]
1 change: 1 addition & 0 deletions docs/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
GeoMakie = "db073c08-6b98-4ee5-b6a4-5efafb3259c6"
GibbsSeaWater = "9a22fb26-0b63-4589-b28e-8f9d0b5c3d05"
Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306"
NCDatasets = "85f8d34a-cbdd-5861-8df4-14fed0d494ab"
OceanRasterConversions = "07ff2621-03e0-4bfb-9812-e5d28c6dbff8"
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
Rasters = "a3a2b9e3-a471-40c9-b274-f788e487c689"
4 changes: 2 additions & 2 deletions examples/ocean_variable_conversion.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# # [Converting the practical salinity and potential temperature from ECCOv4r4 model output.](@id converting_variables_example)
# First, add the required dependencies
using Rasters, Plots, Downloads
using Rasters, NCDatasets, Plots, Downloads
using OceanRasterConversions.OceanVariableConversions
# and download model output from [ECCOv4r4](https://ecco-group.org/products-ECCO-V4r4.htm).
# This data is the daily average 0.5 degree salinity and temperature model output. To reproduce
Expand Down Expand Up @@ -64,7 +64,7 @@ plot!(profile_plots[2, 2], σ₀_profile;

# ## Plotting with [GeoMakie.jl](https://github.com/MakieOrg/GeoMakie.jl)
# Rasters.jl also
# [supports plotting with Makie.jl(https://rafaqz.github.io/Rasters.jl/dev/#Plotting-in-Makie)
# [supports plotting with Makie.jl](https://rafaqz.github.io/Rasters.jl/dev/#Plotting-in-Makie)
# as of version 0.5.3.
# If using an older version we can write a method
# for `convert_arguments` to convert a `Raster` into a format that can be plotted by
Expand Down
2 changes: 1 addition & 1 deletion examples/raster_histograms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# # [Raster Histograms](@id raster_hist_example)
# First, add the required depedencies
using Rasters, Downloads, CairoMakie
using Rasters, NCDatasets, Downloads, CairoMakie
# and the `RasterHistograms` module from OceanRasterConversions.jl package
using OceanRasterConversions.RasterHistograms
# Using this module we can produce `Histogram`s from data that is in a `Raster`,
Expand Down