Add syntax highlighting and collapsing with fountain format for script editor #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I haven't had time to check it out yet, tomorrow I will have 3 hours of high speed train so I will take a better look 💪 |
jbilcke-hf
reviewed
Jul 16, 2024
| const model = editor.getModel(); | ||
| if (model) { | ||
| const fullRange = model.getFullModelRange(); | ||
| model.tokenization.forceTokenization(fullRange.endLineNumber); |
There was a problem hiding this comment.
this triggers the following build error:
Property 'tokenization' does not exist on type 'ITextModel'.
lalalune
force-pushed
the
moon/update-script-editor
branch
3 times, most recently
from
cdedae6 to
680cee8
Compare
lalalune
force-pushed
the
moon/update-script-editor
branch
from
680cee8 to
05138ef
Compare
|
@jbilcke-hf I have refreshed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds syntax highlighting and collapsing / expanding for the fountain format to the script editor.
Solves some but not all of these: #14
I couldn't find anything for fountain and monaco. There is the betterfountain project for vscode, which probably has really nice detailed advanced features. but this solution is relatively simple and seems to get the job done for my test script.
I tried undo/redo buttons and didn't like them. key commands with ctrl z // cmd z work.