Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly sanitize certain iframe attributes #173

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Correctly sanitize certain iframe attributes #173

merged 1 commit into from
Feb 26, 2020

Conversation

jbhannah
Copy link
Owner

Fixes #126.

@coveralls
Copy link

coveralls commented Feb 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 96.753% when pulling 6eead72 on iframe-attributes into df736aa on master.

@jbhannah
fix(amp-iframe): correctly sanitize certain iframe attributes
6eead72 
Fix sanitization of the allowfullscreen, allowtransparency, frameborder, and scrolling properties on
iframe elements

Fixes #126
@jbhannah jbhannah merged commit b01a15d into master Feb 26, 2020
@jbhannah jbhannah deleted the iframe-attributes branch February 26, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitizing/Removing Iframe attributes properly
2 participants
@jbhannah @coveralls