Added test for images w/o extensions #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
reviewed
Jan 4, 2018
test/amperize.test.js
Outdated
| // This test is mocked, but works with this specific example. | ||
| // You can comment out the mocks and the test should still pass. | ||
| sizeOfMock = nock('https://www.zomato.com') | ||
| .get('/logo/18163505/minilogo') |
There was a problem hiding this comment.
Could you add the match headers assertion here as well? 👍
closes jbhannah#97 Images without extensions don't need to be manipulated, as we're now reading the bytes and pass those to the `image-size` lib. This PR adds another `user-agent` to emulate multiple browser requests, as I stumbled over an example where the image without extension is protected otherwise. Added a test, that works with above mentioned image, but is currently mocked. Nevertheless, the image worked as a PoC, that we're able to read the bytes of an image without its extension and still return a valid `amp-img` tag. Updated the README, as there were some code typos in there 🙈.
aileen
force-pushed
the
images-without-extensions
branch
from
8b54ecd to
01e3514
Compare
Repository owner
deleted a comment from
coveralls
Jan 4, 2018
aileen
added a commit
to aileen/amperize
that referenced
this pull request
Jan 4, 2018
no issue Changelog: - Added test for images w/o extensions (jbhannah#109) and new user-agent for image requests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #97
Images without extensions don't need to be manipulated, as we're now reading the bytes and pass those to the
image-sizelib.This PR adds another
user-agentto emulate multiple browser requests, as I stumbled over an example where the image without extension is protected otherwise.Added a test, that works with above mentioned image, but is currently mocked. Nevertheless, the image worked as a PoC, that we're able to read the bytes of an image without its extension and still return a valid
amp-imgtag.Updated the README, as there were some code typos in there 🙈.