Support not putting the full path to the pdb in assemblies #372
Comments
|
Fixed by #380. |
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this issue
Jan 28, 2019
… written to assemblies. We need our 32-bit and 64-bit assemblies to be identical so that we can avoid duplicating the .dll in fat apps. One difference used to be that the .dll contained the full path to the corresponding .pdb ([1]), but we changed cecil to only write the filename ([2]). Unfortunately this change breaks something else, so it has to be reverted ([3]). This implements a different solution: we provide a custom symbol writer to Cecil, which only writes the filename of the pdb in the .dll, not the full path. [1]: https://bugzilla.xamarin.com/show_bug.cgi?id=54578 [2]: jbevain/cecil#372 [3]: jbevain/cecil#554
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this issue
Jan 28, 2019
… written to assemblies. We need our 32-bit and 64-bit assemblies to be identical so that we can avoid duplicating the .dll in fat apps. One difference used to be that the .dll contained the full path to the corresponding .pdb ([1]), but we changed cecil to only write the filename ([2]). Unfortunately this change breaks something else, so it has to be reverted ([3]). This implements a different solution: we provide a custom symbol writer to Cecil, which only writes the filename of the pdb in the .dll, not the full path. [1]: https://bugzilla.xamarin.com/show_bug.cgi?id=54578 [2]: jbevain/cecil#372 [3]: jbevain/cecil#554
akoeplinger
pushed a commit
to xamarin/xamarin-macios
that referenced
this issue
Feb 13, 2019
… written to assemblies. We need our 32-bit and 64-bit assemblies to be identical so that we can avoid duplicating the .dll in fat apps. One difference used to be that the .dll contained the full path to the corresponding .pdb ([1]), but we changed cecil to only write the filename ([2]). Unfortunately this change breaks something else, so it has to be reverted ([3]). This implements a different solution: we provide a custom symbol writer to Cecil, which only writes the filename of the pdb in the .dll, not the full path. [1]: https://bugzilla.xamarin.com/show_bug.cgi?id=54578 [2]: jbevain/cecil#372 [3]: jbevain/cecil#554 (cherry picked from commit 53874c8) # Conflicts: # tools/mtouch/mtouch.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cecil writes the full path to the pdb here: https://github.com/jbevain/cecil/blob/7297b51/Mono.Cecil.Cil/PortablePdb.cs#L304
Supporting a way to only write the filename would fix this: https://bugzilla.xamarin.com/show_bug.cgi?id=54578
Roslyn has a similar issue: dotnet/roslyn#9813
The text was updated successfully, but these errors were encountered: