Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBERET-611 Move the MongoRepository and InfinispanRepository out of j… #598

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

liweinan
Copy link
Contributor

…beret-core

@liweinan liweinan requested a review from a team as a code owner November 26, 2024 14:53
@liweinan
Copy link
Contributor Author

@jamezp I plan to move InfinispanRepository and MongoDbRepository out of jberet-core into their modules. So the dependencies of infinispan and mongodb can be removed from the jberet-core. Could you please help to review this PR when you have time? Thanks!

@liweinan
Copy link
Contributor Author

After discussing with James, this change doesn't affect WildFly. I have checked the modules in WildFly, I confirmed that the WildFly doesn't use InfinispanRespository and MongoRepository:

> ~/w/w/d/t/w/modules on main ◦ find . | grep batch
./system/layers/base/org/wildfly/extension/batch
./system/layers/base/org/wildfly/extension/batch/jberet
./system/layers/base/org/wildfly/extension/batch/jberet/main
./system/layers/base/org/wildfly/extension/batch/jberet/main/wildfly-batch-jberet-35.0.0.Beta1-SNAPSHOT.jar
./system/layers/base/org/wildfly/extension/batch/jberet/main/module.xml
./system/layers/base/jakarta/batch
./system/layers/base/jakarta/batch/api
./system/layers/base/jakarta/batch/api/main
./system/layers/base/jakarta/batch/api/main/jakarta.batch-api-2.1.1.jar
./system/layers/base/jakarta/batch/api/main/module.xml
./system/layers/base/javax/batch
./system/layers/base/javax/batch/api
./system/layers/base/javax/batch/api/main
./system/layers/base/javax/batch/api/main/module.xml

@liweinan
Copy link
Contributor Author

After this is merged, I'll do a major version release because of the project structure change.

@liweinan liweinan merged commit b903c49 into jberet:main Nov 28, 2024
13 checks passed
@liweinan
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant