Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment test #428

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Add deployment test #428

merged 2 commits into from
Dec 14, 2023

Conversation

liweinan
Copy link
Contributor

No description provided.

@liweinan liweinan requested a review from a team as a code owner December 11, 2023 17:48
@liweinan liweinan marked this pull request as draft December 11, 2023 17:48
@liweinan liweinan marked this pull request as ready for review December 12, 2023 15:42
@liweinan liweinan force-pushed the add_deployment_test branch from 0a3f044 to 1a4c9c9 Compare December 13, 2023 15:32
jamezp
jamezp approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. You may need to add copyright headers to the new source files though.

@liweinan
Copy link
Contributor Author

@jamezp Thanks for checking James! I'll update the header and commit the PR.

@liweinan liweinan merged commit dde9cd4 into jberet:main Dec 14, 2023
@liweinan liweinan linked an issue Dec 14, 2023 that may be closed by this pull request
Add deployment tests into the project by using the provisioned WildFly server with the update-to-date project module(by using Galleon feature-pack or WildFly Channel). #417
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@liweinan @jamezp