Skip to content

Commit

Permalink
add note about SendReply err
Browse files Browse the repository at this point in the history
  • Loading branch information
jbenet committed Jun 15, 2015
1 parent 8f823b1 commit e821dad
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion transport/spdystream/spdystream.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ func (c *conn) Serve(handler pst.StreamHandler) {
// -- at this moment -- not the solution. Either spdystream must
// change, or we must throttle another way. go-peerstream handles
// every new stream in its own goroutine.
s.SendReply(http.Header{}, false)
err := s.SendReply(http.Header{}, false)
if err != nil {
// this _could_ error out. not sure how to handle this failure.
// don't return, and let the caller handle a broken stream.
// better than _hiding_ an error.
// return
}
go handler((*stream)(s))
})
}
Expand Down

0 comments on commit e821dad

Please sign in to comment.