Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add App Route: Github User #7

Closed
jbenet opened this issue Nov 19, 2016 · 1 comment
Closed

Add App Route: Github User #7

jbenet opened this issue Nov 19, 2016 · 1 comment

Comments

@jbenet
Copy link
Owner

jbenet commented Nov 19, 2016 •
edited
Loading

Make this route work:

/http/github.com/<user>

This would show all issues assigned to the user.

depends on #3
depends on #11
@jbenet jbenet mentioned this issue Nov 19, 2016
Closed
2 tasks
wking added a commit to wking/depviz that referenced this issue Nov 20, 2016
@wking
DepIndicators: Neutral DependentsIndicator with zero dependents
5128706 
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
wking added a commit to wking/depviz that referenced this issue Nov 20, 2016
@wking
DepIndicators: Neutral DependentsIndicator with zero dependents
ff05162 
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
wking added a commit to wking/depviz that referenced this issue Nov 24, 2016
@wking
DepIndicators: Neutral DependentsIndicator with zero dependents
7c69b7d 
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
@wking
Copy link
Collaborator

wking commented Nov 26, 2016

Done in #11, although I don't walk later result pages yet (unless that happens internally in github-api?). Can we either add a depends on #11 or merge #11 and close this?

@jbenet jbenet closed this as completed Nov 28, 2016
@wking wking mentioned this issue Nov 28, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbenet @wking