changed my mind, including instance in response is redundant

jbellerb · Apr 14, 2024 · b83f9bd · b83f9bd
1 parent eef2d2c
commit b83f9bd
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/migrations/20240414001416_no_response_instance.sql b/migrations/20240414001416_no_response_instance.sql
@@ -0,0 +1 @@
+ALTER TABLE responses DROP COLUMN instance;
diff --git a/routes/[slug]/index.tsx b/routes/[slug]/index.tsx
@@ -109,7 +109,6 @@ export const handler: Handlers<Data, State> = {
       }
 
       const response = new FormResponse(
-        ctx.state.instance.id,
         ctx.state.form.id,
         ctx.state.user.id,
         ctx.state.user.username,

diff --git a/utils/db/schema.ts b/utils/db/schema.ts
@@ -162,8 +162,6 @@ export class Form extends Entity {
 export class FormResponse extends Entity {
   @column("id")
   id: string;
-  @column("instance")
-  instance: string;
   @column("date")
   date: Date;
   @column("form")
@@ -176,15 +174,13 @@ export class FormResponse extends Entity {
   response?: Record<string, string> | null;
 
   constructor(
-    instance: string,
     form: string,
     discordId: bigint,
     discordName: string,
     response?: Record<string, string>,
   ) {
     super();
     this.id = crypto.randomUUID();
-    this.instance = instance;
     this.date = new Date();
     this.form = form;
     this.discordId = discordId;