refactor: rename include_npm_linked_packages to include_npm_sources &…

…& JsInfo npm_linked_packages to npm_sources (aspect-build#1623)
jbedard · May 16, 2024 · a9b32b2 · a9b32b2
1 parent 9b92e5b
commit a9b32b2
Show file tree

Hide file tree

Showing 15 changed files with 86 additions and 51 deletions.
diff --git a/docs/js_binary.md b/docs/js_binary.md
diff --git a/docs/js_info_files.md b/docs/js_info_files.md
diff --git a/docs/js_run_binary.md b/docs/js_run_binary.md
diff --git a/js/defs.bzl b/js/defs.bzl
@@ -26,17 +26,43 @@ load(
     _js_image_layer = "js_image_layer",
 )
 
+# buildifier: disable=function-docstring
 def js_binary(**kwargs):
+    include_npm_sources = kwargs.pop("include_npm_sources", True)
+
+    # For backward compat
+    # TODO(3.0): remove backward compat handling
+    include_npm_linked_packages = kwargs.pop("include_npm_linked_packages", None)
+    if include_npm_linked_packages != None:
+        # buildifier: disable=print
+        print("""
+WARNING: js_binary 'include_npm_linked_packages' is deprecated. Use 'include_npm_sources' instead.""")
+        include_npm_sources = include_npm_linked_packages
+
     _js_binary(
+        include_npm_sources = include_npm_sources,
         enable_runfiles = select({
             Label("@aspect_bazel_lib//lib:enable_runfiles"): True,
             "//conditions:default": False,
         }),
         **kwargs
     )
 
+# buildifier: disable=function-docstring
 def js_test(**kwargs):
+    include_npm_sources = kwargs.pop("include_npm_sources", True)
+
+    # For backward compat
+    # TODO(3.0): remove backward compat handling
+    include_npm_linked_packages = kwargs.pop("include_npm_linked_packages", None)
+    if include_npm_linked_packages != None:
+        # buildifier: disable=print
+        print("""
+WARNING: js_test 'include_npm_linked_packages' is deprecated. Use 'include_npm_sources' instead.""")
+        include_npm_sources = include_npm_linked_packages
+
     _js_test(
+        include_npm_sources = include_npm_sources,
         enable_runfiles = select({
             Label("@aspect_bazel_lib//lib:enable_runfiles"): True,
             "//conditions:default": False,