Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make indirect deduction guides consistent with specification #500

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Make indirect deduction guides consistent with specification #500

merged 1 commit into from
Jan 15, 2025

Conversation

jbcoe
Copy link
Owner

@jbcoe jbcoe commented Jan 15, 2025

No description provided.

@jbcoe jbcoe requested a review from Ukilele January 15, 2025 17:57
@jbcoe jbcoe requested a review from Twon as a code owner January 15, 2025 17:57
@jbcoe jbcoe changed the title Make deduction guides consistent with specification Make indirect deduction guides consistent with specification Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (3e30df8) to head (9fc4c48).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #500   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           7        7           
  Lines         669      669           
  Branches       75       75           
=======================================
  Hits          666      666           
  Misses          3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ukilele
Ukilele approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@Ukilele Ukilele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jbcoe jbcoe merged commit 159f83d into main Jan 15, 2025
32 checks passed
@jbcoe jbcoe deleted the dev-jbcoe-deduction-guide-fix branch January 15, 2025 18:14
@jbcoe jbcoe mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ukilele Ukilele Ukilele approved these changes

@Twon Twon Awaiting requested review from Twon Twon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbcoe @Ukilele