Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup clippy lints #56

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Fixup clippy lints #56

merged 2 commits into from
Jan 20, 2020

Conversation

Hoverbear
Copy link
Collaborator

Fallout from #52

@Hoverbear
Fixup clippy lints
8ddce03 
Signed-off-by: Ana Hobden <[email protected]>
@Hoverbear Hoverbear self-assigned this Jan 20, 2020
@Hoverbear Hoverbear mentioned this pull request Jan 20, 2020
Merged
@Hoverbear
Missed a main
77e5633 
Signed-off-by: Ana Hobden <[email protected]>
@CreepySkeleton
Copy link
Contributor

I would actually recommend you to set clippy as "allow failure" or something.

@Hoverbear
Copy link
Collaborator Author

Thanks for your recommendation, but that's not how this project rolls. :)

@CreepySkeleton
Copy link
Contributor

Hard mode on :) Admirable and a little bit crazy

@Hoverbear
Copy link
Collaborator Author

Yeah -- I'm actually really miffed about the Ci issue on #47/#48, those are the first broken codes to land in getset :(

@Hoverbear Hoverbear merged commit 8ca0d17 into master Jan 20, 2020
@CreepySkeleton
Copy link
Contributor

image

@Hoverbear
Copy link
Collaborator Author

Oh it was totally my fault, don't you feel sad little kitty! I'm grateful for your efforts. :)

@Hoverbear Hoverbear added this to the 0.1.0 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @CreepySkeleton