Accept HTTP/2 protocol

jbaron-gingco · Mar 17, 2016 · d0beee7 · d0beee7
1 parent a714e44
commit d0beee7
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/src/ServerRequestFactory.php b/src/ServerRequestFactory.php
@@ -470,7 +470,7 @@ private static function marshalProtocolVersion(array $server)
             return '1.1';
         }
 
-        if (! preg_match('#^(HTTP/)?(?P<version>[1-9]\d*\.\d)$#', $server['SERVER_PROTOCOL'], $matches)) {
+        if (! preg_match('#^(HTTP/)?(?P<version>[1-9]\d*(?:\.\d)?)$#', $server['SERVER_PROTOCOL'], $matches)) {
             throw new UnexpectedValueException(sprintf(
                 'Unrecognized protocol version (%s)',
                 $server['SERVER_PROTOCOL']

diff --git a/test/ServerRequestFactoryTest.php b/test/ServerRequestFactoryTest.php
@@ -454,14 +454,6 @@ public function testNormalizeFilesReturnsOnlyActualFilesWhenOriginalFilesContain
         $this->assertCount(1, $normalizedFiles['fooFiles']);
     }
 
-    public function testMarshalProtocolVersionReturnsHttpVersion()
-    {
-        $method = new ReflectionMethod('Zend\Diactoros\ServerRequestFactory', 'marshalProtocolVersion');
-        $method->setAccessible(true);
-        $version = $method->invoke(null, ['SERVER_PROTOCOL' => 'HTTP/1.0']);
-        $this->assertEquals('1.0', $version);
-    }
-
     public function testMarshalProtocolVersionRisesExceptionIfVersionIsNotRecognized()
     {
         $method = new ReflectionMethod('Zend\Diactoros\ServerRequestFactory', 'marshalProtocolVersion');
@@ -477,4 +469,24 @@ public function testMarshalProtocolReturnsDefaultValueIfHeaderIsNotPresent()
         $version = $method->invoke(null, []);
         $this->assertEquals('1.1', $version);
     }
+
+    /**
+     * @dataProvider marshalProtocolVersionProvider
+     */
+    public function testMarshalProtocolVersionReturnsHttpVersions($protocol, $expected)
+    {
+        $method = new ReflectionMethod('Zend\Diactoros\ServerRequestFactory', 'marshalProtocolVersion');
+        $method->setAccessible(true);
+        $version = $method->invoke(null, ['SERVER_PROTOCOL' => $protocol]);
+        $this->assertEquals($expected, $version);
+    }
+
+    public function marshalProtocolVersionProvider()
+    {
+        return [
+            'HTTP/1.0' => ['HTTP/1.0', '1.0'],
+            'HTTP/1.1' => ['HTTP/1.1', '1.1'],
+            'HTTP/2'   => ['HTTP/2', '2'],
+        ];
+    }
 }