Allow JREs #1542
Draft
Allow JREs #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 121 121
Lines 7409 7428 +19
Branches 1199 1203 +4
=====================================
- Misses 7409 7428 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
quintesse
force-pushed
the
allow_jres
branch
3 times, most recently
from
682e137 to
cff5b07
Compare
quintesse
force-pushed
the
allow_jres
branch
2 times, most recently
from
bdeb116 to
3f65088
Compare
If it finds both a `java` and `javac` on the path that don't point to the same JDK it will returns both options.
This can be used to determine which JDKs are actually JREs and which ones are full JDKs.
quintesse
force-pushed
the
allow_jres
branch
from
3f65088 to
d32a2f5
Compare
|
rebase? |
|
Still not marked as ready :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows JREs to be used by Jbang. This should make it possible to use much of Jbang's functionality without having a JDK installed. Except for the most important of course, which is being able to
build.But this will let you for example list the available JDKs and decide which one you want to install, instead of Jbang first installing a default version, like 11, before it will allow you do do anything else.