Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pytest!=5.1.2 #897

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Pin pytest!=5.1.2 #897

merged 1 commit into from
Sep 17, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Sep 15, 2019 •
edited
Loading

Closes #885.

@atugushev
Pin pytest!=5.1.2
058b764 
See jazzband#885 for the details.
@atugushev atugushev requested a review from codingjoe September 15, 2019 21:36
@atugushev atugushev added bug fix tests Testing and related things labels Sep 15, 2019
@atugushev atugushev requested a review from jayvdb September 16, 2019 15:27
@atugushev
Copy link
Member Author

@jayvdb could you review this, so we can make CI green in #889 and the other PRs?

@atugushev atugushev closed this Sep 16, 2019
@atugushev atugushev reopened this Sep 16, 2019
@codecov
Copy link

codecov bot commented Sep 16, 2019 •
edited
Loading

Codecov Report

Merging #897 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          35       35           
  Lines        2230     2230           
  Branches      285      285           
=======================================
  Hits         2209     2209           
  Misses         13       13           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de5db6...058b764. Read the comment docs.

@atugushev
Copy link
Member Author

I've reopened it since it's the only way to trigger codecov reporter :( see https://community.codecov.io/t/github-bot-doesnt-report-pr/494/14

codingjoe
codingjoe approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍thanks @atugushev

@aaugustin aaugustin merged commit d6d631e into jazzband:master Sep 17, 2019
@atugushev
Copy link
Member Author

Thank you @codingjoe for reviewing this and @aaugustin for merging!

@atugushev atugushev deleted the exclude-pytest-5.1.2-issue-885 branch September 17, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingjoe codingjoe codingjoe approved these changes

@jayvdb jayvdb Awaiting requested review from jayvdb

Assignees

@aaugustin aaugustin

Labels
tests Testing and related things
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest==5.1.2 breaks test_diff_with_editable on py35+ (windows)
3 participants
@atugushev @codingjoe @aaugustin