-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore ability to set compile cache with env var PIP_TOOLS_CACHE_DIR #1368
Conversation
Fixes bug introduced in jazzbandGH-1238 and exposed by jazzbandGH-1357
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 33 33
Lines 2940 2940
Branches 308 308
=======================================
Hits 2930 2930
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Looks like it was removed accidentally.
@atugushev Sorry to bother you. I see, that you added this to the version |
Hello @ruro! Thanks for pinging.
We are waiting for #1363 to be merged. It's in the review process for now. Unfortunately no ETA.
It would take some effort, we haven't done backports before. I'd prefer to wait for |
I have a GitHub App for easier backports (when they apply cleanly) but this would probably require supporting multiple release streams and an extra RM to handle release tasks. |
No problems, if you don't have a simple way to do a backport, then I'll just wait for 1363/ |
|
Fixes bug introduced in #1238 and exposed by #1357
#1238's intent was to remove unnecessary environment variable handling that pip was taking care of. This pip-tools environment variable was an accidental casualty. This became apparent when parallel tests proved unstable, due to a shared cache path, while we already have an autouse fixture to isolate them (using
PIP_TOOLS_CACHE_DIR
env var).Changelog-friendly one-liner: Restore ability to set compile cache with env var
PIP_TOOLS_CACHE_DIR
Contributor checklist