Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

future: cache editables in memory during the current run #159

Closed
blueyed opened this issue May 12, 2015 · 2 comments
Closed

future: cache editables in memory during the current run #159

blueyed opened this issue May 12, 2015 · 2 comments

Comments

@blueyed
Copy link
Contributor

blueyed commented May 12, 2015

I've noticed that editable VCS dependencies get fetched multiple times during the same run, but they could and should be cached during the current run.

Apart from improving performance, this makes also sure that they do not change during the run.

IIRC I've changed that in the former future branch, before the rewrite.

I could imagine adding a MemoryDependencyCache, which behaves like DependencyCache, but would not read/write anything.

What do you think?
blueyed added a commit to blueyed/pip-tools that referenced this issue May 12, 2015
@blueyed
PyPIRepository: cache return value of get_dependencies
8609b52 
This improves performance, especially for VCS editable dependencies.

Fixes: jazzband#159
@blueyed blueyed mentioned this issue May 12, 2015
Closed
@blueyed
Copy link
Contributor Author

blueyed commented May 12, 2015

While this change is probably good anyway, I'd really like to cache the editables also for a certain period, e.g. 5 minutes.
When building the requirements for my project, I call pip-compile for multiple requirements.in files (dev, testing, production), and they should all use the cached result from the first run.

blueyed added a commit to blueyed/pip-tools that referenced this issue Jun 17, 2015
@blueyed
PyPIRepository: cache return value of get_dependencies
4ff0c7f 
This improves performance, especially for VCS editable dependencies,
where it is also required for pip not barking out because of an existing
source/build directory.

Fixes: jazzband#159
blueyed added a commit to blueyed/pip-tools that referenced this issue Jun 20, 2015
@blueyed
PyPIRepository: cache return value of get_dependencies
5aaa2fd 
This improves performance, especially for VCS editable dependencies,
where it is also required for pip not barking out because of an existing
source/build directory.

Fixes: jazzband#159
blueyed added a commit to blueyed/pip-tools that referenced this issue Jun 25, 2015
@blueyed
PyPIRepository: cache return value of get_dependencies
82aec97 
This improves performance, especially for VCS editable dependencies,
where it is also required for pip not barking out because of an existing
source/build directory.

Fixes: jazzband#159
@davidovich
Copy link
Contributor

This was implemented in PR #476 to fix a new bug introduced in 1.8.1. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blueyed @davidovich