Skip to content

Commit

Permalink
Make the --build-isolation flag set on by default for pip-compile.
Browse files Browse the repository at this point in the history
  • Loading branch information
hramezani committed Mar 3, 2020
1 parent 888c2a1 commit d75234d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion piptools/repositories/pypi.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class PyPIRepository(BaseRepository):
changed/configured on the Finder.
"""

def __init__(self, pip_args, cache_dir, build_isolation=False):
def __init__(self, pip_args, cache_dir, build_isolation=True):
# Use pip's parser for pip.conf management and defaults.
# General options (find_links, index_url, extra_index_url, trusted_host,
# and pre) are deferred to pip.
Expand Down
2 changes: 1 addition & 1 deletion piptools/scripts/compile.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
@click.option(
"--build-isolation/--no-build-isolation",
is_flag=True,
default=False,
default=True,
help="Enable isolation when building a modern source distribution. "
"Build dependencies specified by PEP 518 must be already installed "
"if build isolation is disabled.",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def test_force_text(value, expected_text):
(["--annotate"], "pip-compile"),
(["--index"], "pip-compile"),
(["--max-rounds=10"], "pip-compile"),
(["--no-build-isolation"], "pip-compile"),
(["--build-isolation"], "pip-compile"),
# Check options with multiple values
(
["--find-links", "links1", "--find-links", "links2"],
Expand Down

0 comments on commit d75234d

Please sign in to comment.