Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox doesn't install simple_menu in GH Actions #123

Closed
kytta opened this issue Jan 16, 2023 · 2 comments · Fixed by #124
Closed

tox doesn't install simple_menu in GH Actions #123

kytta opened this issue Jan 16, 2023 · 2 comments · Fixed by #124
Labels
bug Something doesn't work the way it should

Comments

@kytta
Copy link
Member

kytta commented Jan 16, 2023 •
edited
Loading

First arisen in the workflow for #122. It seems like tox doesn't install simple_menu for some reason.

Compare the dependency step of the succeeded py36-dj32 run versus the failed py37-dj32 run.
@kytta kytta added the bug Something doesn't work the way it should label Jan 16, 2023
@kytta
Copy link
Member Author

kytta commented Jan 16, 2023

Probably has something to do with tox v4 release: https://tox.wiki/en/latest/upgrading.html as it doesn't occur on Python 3.6 which doesn't support tox 4

@kytta
Copy link
Member Author

kytta commented Mar 11, 2023

Found the issue: tox-dev/tox#2730

kytta added a commit that referenced this issue Mar 11, 2023
@kytta
Remove skipdist
f90180d 
In tox v4, "skipdist" together with "usedevelop" do not work:
tox-dev/tox#2730

I do not understand why we use both options, since we do not lint the
code with tox (or similar), so we actually need to install the package
every time.

Closes #123
@kytta kytta mentioned this issue Mar 11, 2023
Merged
kytta added a commit that referenced this issue Mar 11, 2023
@kytta
Fix tox testing (#124)
cd2c8c7 
See also: tox-dev/tox#2730

Closes #123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't work the way it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tox testing jazzband/django-simple-menu
1 participant
@kytta