Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m2m historical records are saved even when SIMPLE_HISTORY_ENABLED = False #1328

Closed
MattFanto opened this issue May 12, 2024 · 0 comments · Fixed by #1329
Closed

m2m historical records are saved even when SIMPLE_HISTORY_ENABLED = False #1328

MattFanto opened this issue May 12, 2024 · 0 comments · Fixed by #1329

Comments

@MattFanto
Copy link
Contributor

Describe the bug
m2m relationships ignores the SIMPLE_HISTORY_ENABLED = False, even when disabled the library is still saving the historical record.
This is causing me some issue when loading Django fixture using loaddata

To Reproduce
Steps to reproduce the behavior:

  1. set SIMPLE_HISTORY_ENABLED = False
  2. save a m2m relationship
  3. you will see the record in the historical DB

Expected behavior
If SIMPLE_HISTORY_ENABLED = False no historical record should be created for m2m relationship

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: Ubuntu 22
  • Browser (if applicable): [e.g. chrome, safari]
  • Django Simple History Version: [e.g. 1.9.1]
  • Django Version: [e.g. 1.11.11]
  • Database Version: PostgreSQL 15
@MattFanto MattFanto changed the title m2m historical record is still save even when SIMPLE_HISTORY_ENABLED = False m2m historical records are saved even when SIMPLE_HISTORY_ENABLED = False May 12, 2024
@MattFanto MattFanto mentioned this issue May 12, 2024
Merged
11 tasks
b1rger added a commit to acdh-oeaw/apis-core-rdf that referenced this issue Jun 18, 2024
@b1rger
chore(deps): bump django-simple-history minmal version
195d12a 
version 3.6 of simple history fixes this bug:
jazzband/django-simple-history#1328 which is
useful when we want to disable simple history to circumvent this bug
jazzband/django-simple-history#1354
@b1rger b1rger mentioned this issue Jun 18, 2024
Merged
b1rger added a commit to acdh-oeaw/apis-core-rdf that referenced this issue Jun 19, 2024
@b1rger
chore(deps): bump django-simple-history minmal version
1059706 
version 3.6 of simple history fixes this bug:
jazzband/django-simple-history#1328 which is
useful when we want to disable simple history to circumvent this bug
jazzband/django-simple-history#1354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix m2m saved when simple history disabled MattFanto/django-simple-history
1 participant
@MattFanto