Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and Test Against Django 5 #686

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

albertyw
Copy link
Member

@albertyw albertyw commented Nov 25, 2023

Depends on #669
Depends on #685
Depends on #687
Depends on #692
Depends on #699

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bc0f26) 86.75% compared to head (adbf87c) 86.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   86.75%   86.76%           
=======================================
  Files          52       52           
  Lines        2114     2115    +1     
=======================================
+ Hits         1834     1835    +1     
  Misses        280      280           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertyw albertyw force-pushed the django-5 branch 4 times, most recently from 666ed85 to 59c2dae Compare December 2, 2023 23:15
Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for contributing this patch. This looks good to me. No idea why tox failed for 3.12 support but I have restarted the pipeline. Making a cross-test locally as well, in 3.12.a14 to get some insights.

Other than that, we all good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@albertyw albertyw force-pushed the django-5 branch 3 times, most recently from f778339 to 98dd2bd Compare December 30, 2023 21:06
@albertyw
Copy link
Member Author

Looking at logs, it seems the tests are failing due to ValueError: Another profiling tool is already active which was reported in #682

50-Course

This comment was marked as outdated.

@50-Course 50-Course self-requested a review January 1, 2024 01:20
50-Course pushed a commit that referenced this pull request Jan 8, 2024
Fix concurrent profilers error (potentially unblocks #686)
@albertyw albertyw force-pushed the django-5 branch 2 times, most recently from 89ec83e to f7cccc6 Compare January 16, 2024 05:42
@albertyw albertyw merged commit 510693f into jazzband:master Jan 19, 2024
22 checks passed
@albertyw albertyw deleted the django-5 branch January 19, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants