-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support and Test Against Django 5 #686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
=======================================
Coverage 86.75% 86.76%
=======================================
Files 52 52
Lines 2114 2115 +1
=======================================
+ Hits 1834 1835 +1
Misses 280 280 ☔ View full report in Codecov by Sentry. |
666ed85
to
59c2dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thank you for contributing this patch. This looks good to me. No idea why tox failed for 3.12 support but I have restarted the pipeline. Making a cross-test locally as well, in 3.12.a14
to get some insights.
Other than that, we all good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍🏼
f778339
to
98dd2bd
Compare
Looking at logs, it seems the tests are failing due to |
Fix concurrent profilers error (potentially unblocks #686)
89ec83e
to
f7cccc6
Compare
Depends on #669
Depends on #685
Depends on #687
Depends on #692
Depends on #699