Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow APNS tokens of variable length. #678

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

ianlater
Copy link
Contributor

@ianlater ianlater commented Feb 7, 2023

Hopefully solves #537


if hex_re.match(value) is None or len(value) not in (64, 200):
# https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1622958-application
# As of 02/2023 APNS tokens (registration_id) "are of variable length. Do not hard-code their size."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# As of 02/2023 APNS tokens (registration_id) "are of variable length. Do not hard-code their size."
# As of 02/2023, APNs device tokens (registration_id) are of variable length. Do not hard-code their size.

@azmeuk azmeuk mentioned this pull request Jul 24, 2023
@azmeuk azmeuk added the apns label Aug 18, 2023
@jamaalscarlett jamaalscarlett merged commit 10639a2 into jazzband:master Aug 19, 2023
blighj pushed a commit to blighj/django-push-notifications that referenced this pull request Sep 30, 2023
50-Course pushed a commit that referenced this pull request Oct 3, 2024
50-Course pushed a commit that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants