-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for Django 5.1, add support for new STORAGES setting #524
Conversation
updated changelog removed unused import
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 91.40% 90.97% -0.44%
==========================================
Files 19 19
Lines 873 886 +13
Branches 157 159 +2
==========================================
+ Hits 798 806 +8
- Misses 40 43 +3
- Partials 35 37 +2 ☔ View full report in Codecov by Sentry. |
Converting to draft until tests are added. |
for more information, see https://pre-commit.ci
I'm okay with a breaking change that completely removes the |
I think I'd prefer that as another PR. That would also imply dropping support for Django <4.2 and would require a rewrite of some existing tests (e.g. I believe FakeStorage does currently not work for mediabackup etc.) |
great. Just ran into this. When will this be released on pip? |
Will be released today. |
Description
get_storage_class
to replace the removed method in Django 5.1 and avoid breaking changesExample:
The previous DBBACKUP_STORAGE and DBBACKUP_STORAGE_OPTIONS are still valid and take precedence.
Fixes #522 and should also fix #523.
Please double check if I missed anything.
What confused me a bit was that for the DB Storage this package always uses the configured DBBACKUP_STORAGE, while the mediabackup storage always uses the default django storage. I kept this behavior to not break anything.
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).