Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build and URLs #437

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Fix docs build and URLs #437

merged 2 commits into from
Apr 29, 2022

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Apr 29, 2022

Looks like PR #414 broke our docs build. This PR fixes that, and cleans up the URLs within the docs.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #437 (2ead2a0) into master (246c1dd) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   90.87%   90.94%   +0.06%     
==========================================
  Files          19       19              
  Lines         855      861       +6     
  Branches      173      173              
==========================================
+ Hits          777      783       +6     
  Misses         42       42              
  Partials       36       36              
Impacted Files Coverage Δ
dbbackup/__init__.py 75.00% <100.00%> (+75.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 246c1dd...2ead2a0. Read the comment docs.

@Archmonger Archmonger requested a review from johnthagen April 29, 2022 07:48
@johnthagen
Copy link
Contributor

@Archmonger Sorta related to this, should we add a pyproject.toml for this project to properly specify build-time dependencies?

@Archmonger
Copy link
Contributor Author

I think pyproject.toml belongs in #438 so I'll merge this as is

@Archmonger Archmonger merged commit 62323e4 into master Apr 29, 2022
@Archmonger Archmonger deleted the fix-docs branch April 29, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants