-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dbrestore on SQLite #383
Conversation
Adding @rgaiacs changes about restoring to sqlite db with newlines
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 91.40% 91.22% -0.19%
==========================================
Files 19 19
Lines 873 912 +39
Branches 157 164 +7
==========================================
+ Hits 798 832 +34
- Misses 40 43 +3
- Partials 35 37 +2 ☔ View full report in Codecov by Sentry. |
@johnthagen You mentioned something about the functional tests on this repo being iffy. Do you think that might be the reason why the Unrelated note, I confirmed at least one issue on Windows appears to be related to |
I don't fully recall.
Maybe *nix specific tests like |
I'd need to confirm whether they should be skipped or not. It's very possible these tests failing is an indication that encryption support is broken on Windows. |
I have been working with Django in the last couple of years. Sorry for not be able to resolve the conflicts. |
for more information, see https://pre-commit.ci
This can be merged after hitting full codecov. Seems like there's two logical branches that aren't being tested. if line_str.startswith("INSERT") and not line_str.endswith(");\n"):
sql_is_complete = False
continue if not sql_is_complete and line_str.endswith(");\n"):
sql_is_complete = True |
Adding test to restore a dump with a field containing newline
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you for the PR!
Adding @rgaiacs changes about restoring to sqlite db with newlines
Bug fix
Description
This change fix a pb when restoring fields that contains newlines.