Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #344 - Run tests on python 3.11 #345

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fixed #344 - Run tests on python 3.11 #345

merged 1 commit into from
Nov 4, 2022

Conversation

pauloxnet
Copy link
Member

@pauloxnet pauloxnet commented Oct 25, 2022 •
edited
Loading

Fixed #344

@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #345 (df41e7f) into master (17ca033) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          25       25           
  Lines        1195     1195           
  Branches      235      215   -20     
=======================================
  Hits         1075     1075           
  Misses         89       89           
  Partials       31       31

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueyed
blueyed reviewed Oct 26, 2022
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@pauloxnet pauloxnet force-pushed the issue/344 branch 2 times, most recently from 4d0253b to 7affe36 Compare November 1, 2022 10:08
@pauloxnet
Copy link
Member Author

Can I ask someone to review and eventually merge this PR?
Please use the "rebase and merge" button

michael-k
michael-k requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@michael-k michael-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the trove classifier to setup.py.

@pauloxnet
Copy link
Member Author

Please also add the trove classifier to setup.py.

Done.
Thanks for the review.

michael-k
michael-k approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@michael-k michael-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blueyed blueyed merged commit 1f8bac5 into jazzband:master Nov 4, 2022
@blueyed
Copy link
Contributor

blueyed commented Nov 4, 2022 •
edited
Loading

@pauloxnet
Thanks!

Please use the "rebase and merge" button

Done.
Just out of curiosity, (why) do you prefer it over the squash button? Or is it mainly about not using the default merge action?

@pauloxnet
Copy link
Member Author

Done.

Thanks!

Just out of curiosity, (why) do you prefer it over the squash button?

As you said it's mainly about not using the default merge action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-k michael-k michael-k approved these changes

@blueyed blueyed blueyed approved these changes

@camilonova camilonova Awaiting requested review from camilonova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests on python 3.11
3 participants
@pauloxnet @blueyed @michael-k