Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare next release 2.4 #338

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Prepare next release 2.4 #338

merged 2 commits into from
Aug 25, 2022

Conversation

pauloxnet
Copy link
Member

@pauloxnet pauloxnet commented Aug 23, 2022 •
edited
Loading

Fix #339

@pauloxnet pauloxnet requested review from jezdez and blueyed August 23, 2022 10:11
@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #338 (e1c4343) into master (7e473d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          25       25           
  Lines        1195     1195           
  Branches      235      235           
=======================================
  Hits         1075     1075           
  Misses         89       89           
  Partials       31       31

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pauloxnet pauloxnet mentioned this pull request Aug 24, 2022
Closed
michael-k
michael-k approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@michael-k michael-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/changes.rst Outdated Show resolved Hide resolved
blueyed
blueyed approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also, but the changelog suggestion makes sense.

From what I can tell it only updates the meta information (#337).

@pauloxnet @michael-k
Update docs/changes.rst
e1c4343 
Co-authored-by: Michael K. <[email protected]>
@pauloxnet
Copy link
Member Author

Thanks for the suggestions, I've updated this PR

@pauloxnet pauloxnet merged commit 40d244d into jazzband:master Aug 25, 2022
@pauloxnet
Copy link
Member Author

@jezdez @blueyed @michael-k
Given your approvals I merged this PR.
How will the new version now be released?

@michael-k
Copy link
Contributor

There's a release workflow. Pushing the appropriate tag should be sufficient.

@pauloxnet
Copy link
Member Author

There's a release workflow. Pushing the appropriate tag should be sufficient.

@michael-k I created the new tag
https://github.com/jazzband/django-configurations/releases/tag/2.4

@michael-k
Copy link
Contributor

According to https://jazzband.co/projects/django-configurations @jezdez and @blueyed are the leads on this project and are responsible for uploading releases to PyPI.

@jezdez
Copy link
Member

jezdez commented Sep 1, 2022

According to https://jazzband.co/projects/django-configurations @jezdez and @blueyed are the leads on this project and are responsible for uploading releases to PyPI.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-k michael-k michael-k approved these changes

@blueyed blueyed blueyed approved these changes

@jezdez jezdez jezdez approved these changes

@brianhelba brianhelba Awaiting requested review from brianhelba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release a new version on PyPi
4 participants
@pauloxnet @michael-k @jezdez @blueyed